Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate community page folder and their related components to typescript #2857

Merged
merged 24 commits into from
Apr 21, 2024
Merged

feat: migrate community page folder and their related components to typescript #2857

merged 24 commits into from
Apr 21, 2024

Conversation

devilkiller-ag
Copy link
Member

@devilkiller-ag devilkiller-ag commented Apr 9, 2024

Description
This PR migrates the components inside the following folder to TypeScript:

pages/community

  • ambassadors folder
  • events folder
  • GeneratorInstallation
  • newsroom
  • tsc
  • dashboard
  • index

components/dashboard

  • table folder
  • Button
  • GoodFirstIssues
  • GoodFirstIssuesTip
  • Header

Related issue(s)
#2636

Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ce6a304
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6624a2cbc0a1d100085335e6
😎 Deploy Preview https://deploy-preview-2857--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devilkiller-ag
Copy link
Member Author

There are some styling issues in the following sections of Events page and /community page:

How it should look Now
image image
image image
image image
Heading similar to image image

Done

@devilkiller-ag
Copy link
Member Author

Everything else looks good, There are some places where the normal text differs in typography. Maybe not related to this PR. Would be a cherry on top, if you could add a fix to it

How it looks now: image

How it should have been (Notice the font): image

I think this is happening due to usage of:

import { Inter } from 'next/font/google';
const inter = Inter({ subsets: ['latin'] });

in the pages/index.tsx. Should I change it to Work Sans?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there changes to workflow files?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there a change to this file?

@anshgoyalevil
Copy link
Member

@devilkiller-ag Seems like there is some rebase issue with the PR since it contains changes from the master branch.
Please revert the changes from master branch.

This reverts commit 9cdcfe5, reversing
changes made to b65ce95.
@anshgoyalevil
Copy link
Member

The Newsletter Signup Heading need not be hardcoded to white on community/tsc page.

image


On community/events page

image
needs to be like
image

nit: a space after Host:
image


On community/newsroom page

A space after stories.
image


Typography thing seems to be resolved, but the size of certain text on /community page is small as compared to master branch deployment.

Previous This PR
image image
image image

@devilkiller-ag
Copy link
Member Author

Hi @anshgoyalevil Everything has been resolved, expect for this one:

On community/events page

image needs to be like image

Copy link
Member

@anshgoyalevil anshgoyalevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@anshgoyalevil
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 2467a3a into asyncapi:migrate-ts Apr 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants